Skip to content

ci: javadoc job (JDK 17) in ci.yaml (#1819)#1276

Merged
suztomo merged 2 commits intomainfrom
owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
Jul 8, 2023
Merged

ci: javadoc job (JDK 17) in ci.yaml (#1819)#1276
suztomo merged 2 commits intomainfrom
owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jun 27, 2023

This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

@gcf-owl-bot
ci: javadoc job (JDK 17) in ci.yaml (#1819)
598e39f 
This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
@gcf-owl-bot gcf-owl-bot bot requested review from a team June 27, 2023 18:56
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 27, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Jun 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023
@suztomo
Copy link
Member

suztomo commented Jul 7, 2023

The error seems trivial https://github.com/googleapis/java-spanner-jdbc/actions/runs/5393567712/jobs/9793489055?pr=1276

Error:  /home/runner/work/java-spanner-jdbc/java-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/CloudSpannerJdbcConnection.java:39: error: reference not found
Error:   * <p>Calling {@link Connection#unwrap(Class)} with {@link CloudSpannerJdbcConnection#getClass()} as
Error:

I'm fixing it.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2023
@suztomo
Copy link
Member

suztomo commented Jul 7, 2023

@googleapis/api-spanner-java Would you review this change?

@suztomo suztomo merged commit bd4dedd into main Jul 8, 2023
@suztomo suztomo deleted the owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 branch July 8, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

+2 more reviewers

@arpan14 arpan14 arpan14 approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. owl-bot-update-lock size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @arpan14 @rajatbhatta @yoshi-kokoro