Skip to content

test: fix assert for testConnectWithCredentialsAndOAuthToken#882

Closed
rajatbhatta wants to merge 2 commits intomainfrom
jdbc-driver-test-fix
Closed

test: fix assert for testConnectWithCredentialsAndOAuthToken#882
rajatbhatta wants to merge 2 commits intomainfrom
jdbc-driver-test-fix

Conversation

@rajatbhatta
Copy link
Contributor

testConnectWithCredentialsAndOAuthToken test was failing with following error -
JdbcDriverTest.testConnectWithCredentialsAndOAuthToken:135 expected to contain: Cannot specify both credentials and an OAuth token
but was : INVALID_ARGUMENT: Specify only one of credentialsUrl, encodedCredentials, credentialsProvider and OAuth token.

Changing assertThat to account for this change. The exception message was changed as part of googleapis/java-spanner#1869.

testConnectWithCredentialsAndOAuthToken test was failing with following error -
JdbcDriverTest.testConnectWithCredentialsAndOAuthToken:135 expected to contain: Cannot specify both credentials and an OAuth token
but was : INVALID_ARGUMENT: Specify only one of credentialsUrl, encodedCredentials, credentialsProvider and OAuth token.

Changing assertThat to account for this change. The exception message was changed as part of googleapis/java-spanner#1869.
@rajatbhatta rajatbhatta requested review from a team, ansh0l and olavloite May 26, 2022 10:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels May 26, 2022
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rajatbhatta
Copy link
Contributor Author

Closing this PR as this commit was added as part of #881.

@rajatbhatta rajatbhatta deleted the jdbc-driver-test-fix branch May 31, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants