fix: Types.BOOLEAN and Types.BIT should have identical behaviour for nullability#920
Merged
rajatbhatta merged 3 commits intogoogleapis:mainfrom Aug 26, 2022
Merged
Conversation
…bility. In master, BOOLEAN is nullable but BIT will throw IllegalArgumentException if an attempt is made to set a null value.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…nullability. In master, BOOLEAN is nullable but BIT will throw IllegalArgumentException if an attempt is made to set a null value.
…panner-jdbc into bug-nullable_bit_type
rajatbhatta
approved these changes
Aug 25, 2022
Contributor
rajatbhatta
left a comment
There was a problem hiding this comment.
LGTM. Adding @olavloite to take a look as well.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.7](v2.7.6...v2.7.7) (2022-09-16) ### Bug Fixes * Types.BOOLEAN and Types.BIT should have identical behaviour for nullability ([#920](#920)) ([42e5903](42e5903)) ### Dependencies * Google-cloud-spanner-bom 6.30.0 ([#967](#967)) ([9385a5d](9385a5d)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#963](#963)) ([811d96b](811d96b)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#966](#966)) ([f8b88cd](f8b88cd)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.29.0 ([#943](#943)) ([9754023](9754023)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.29.1 ([#961](#961)) ([a3e1fc6](a3e1fc6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types.BOOLEAN and Types.BIT should have identical behaviour for nullability. In master, BOOLEAN is nullable but BIT will throw IllegalArgumentException if an attempt is made to set a null value.
Fixes #919