Skip to content

feat: add tests for DML with Returning clause#936

Merged
gcf-merge-on-green[bot] merged 11 commits intogoogleapis:mainfrom
rajatbhatta:dml-returning-parsing-changes
Nov 21, 2022
Merged

feat: add tests for DML with Returning clause#936
gcf-merge-on-green[bot] merged 11 commits intogoogleapis:mainfrom
rajatbhatta:dml-returning-parsing-changes

Conversation

@rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Aug 22, 2022 •
edited
Loading

This PR adds tests for running DML with Returning clause using the JDBC driver, and incorporates the following:

  • Integration tests for running DML statements with Returning clause using PreparedStatement.
  • Unit tests for running DML statements with Returning clause using JdbcStatement, for each of the available JDBC APIs execute, executeUpdate, executeQuery, executeBatchUpdate.
  • The JDBC driver does not require any code changes for supporting DML with Returning clause, as all the required changes will be made in the Connection API (Connection API changes are being tracked at feat: support DML with Returning clause in Connection API java-spanner#1978).

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Aug 22, 2022
@rajatbhatta rajatbhatta marked this pull request as ready for review August 22, 2022 17:41
@rajatbhatta rajatbhatta requested review from a team, ansh0l and olavloite August 22, 2022 17:41
@rajatbhatta
Copy link
Contributor Author

rajatbhatta commented Aug 22, 2022

Note: Integration tests are not expected to pass until DML with Returning clause support is launched.

olavloite
olavloite approved these changes Aug 23, 2022
View reviewed changes
@rajatbhatta rajatbhatta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2022
@rajatbhatta rajatbhatta self-assigned this Aug 23, 2022
thiagotnunes
thiagotnunes reviewed Aug 25, 2022
View reviewed changes
@rajatbhatta rajatbhatta mentioned this pull request Aug 30, 2022
Closed
@rajatbhatta rajatbhatta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 9, 2022
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8a86467 into googleapis:main Nov 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 21, 2022
@release-please release-please bot mentioned this pull request Nov 21, 2022
Merged
@rajatbhatta rajatbhatta deleted the dml-returning-parsing-changes branch November 21, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

@ansh0l ansh0l Awaiting requested review from ansh0l

+1 more reviewer

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajatbhatta rajatbhatta

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajatbhatta @thiagotnunes @olavloite @yoshi-kokoro