Skip to content

chore(test): slightly restructure BackendResources to make more friendly to adding new values to Backends#2577

Merged
BenWhitehead merged 1 commit intomainfrom
test/more-backends
Jun 6, 2024
Merged

chore(test): slightly restructure BackendResources to make more friendly to adding new values to Backends#2577
BenWhitehead merged 1 commit intomainfrom
test/more-backends

Conversation

@BenWhitehead
Copy link
Collaborator

Universes as well as adhoc dev are likely on the horizon, this PR makes it easier to add new backends in the integration test runner.

By using a switch instead of a ternary new switch branches can be added in a diff and easily re-applied.

By passing the list of RegistryEntries directly to the constructor makes it easier for a diff to insert new elements.

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 5, 2024
@BenWhitehead BenWhitehead requested a review from a team June 5, 2024 19:17
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Jun 5, 2024
@BenWhitehead BenWhitehead merged commit 2ad8f92 into main Jun 6, 2024
@BenWhitehead BenWhitehead deleted the test/more-backends branch June 6, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants