Skip to content

feat: expose the methods of Notifications#399

Merged
sydney-munro merged 18 commits intogoogleapis:mainfrom
athakor:storage-notification-138
Mar 25, 2022
Merged

feat: expose the methods of Notifications#399
sydney-munro merged 18 commits intogoogleapis:mainfrom
athakor:storage-notification-138

Conversation

@athakor
Copy link
Contributor

@athakor athakor commented Jun 30, 2020

Addressed the feedback of #393

Fixes #138

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2020
@athakor athakor requested review from JesseLovelace and frankyn June 30, 2020 08:55
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@48b99be). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e5763f1 differs from pull request most recent head 9d97576. Consider uploading reports for the commit 9d97576 to get more accurate results

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage        ?   64.71%           
  Complexity      ?      657           
=======================================
  Files           ?       34           
  Lines           ?     5529           
  Branches        ?      546           
=======================================
  Hits            ?     3578           
  Misses          ?     1779           
  Partials        ?      172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b99be...9d97576. Read the comment docs.

dmitry-fa
dmitry-fa suggested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@dmitry-fa dmitry-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use @param for arguments when you write javadoc for method

@athakor
Copy link
Contributor Author

athakor commented Jul 2, 2020

@dmitry-fa all the comments have been addressed PTAL

@athakor
Copy link
Contributor Author

athakor commented Jul 6, 2020

@dmitry-fa PTAL

1 similar comment
@athakor
Copy link
Contributor Author

athakor commented Jul 13, 2020

@dmitry-fa PTAL

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2020
dmitry-fa
dmitry-fa reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@dmitry-fa dmitry-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It becomes more and more clear. Some minor things to fix left.

@athakor athakor added the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2020
@frankyn frankyn removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2020
@googleapis googleapis deleted a comment from gcf-merge-on-green bot Jul 14, 2020
dmitry-fa
dmitry-fa suggested changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@dmitry-fa dmitry-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor corrections to the doc

@athakor
Copy link
Contributor Author

athakor commented Jul 14, 2020

@dmitry-fa all the comments have been addressed PTAL

@sydney-munro sydney-munro requested a review from a team March 17, 2022 23:13
@sydney-munro sydney-munro force-pushed the storage-notification-138 branch 3 times, most recently from b56cc01 to 300c604 Compare March 18, 2022 22:06
@googleapis googleapis deleted a comment from generated-files-bot bot Mar 18, 2022
@googleapis googleapis deleted a comment from snippet-bot bot Mar 18, 2022
@sydney-munro sydney-munro force-pushed the storage-notification-138 branch from 300c604 to 8489ff2 Compare March 18, 2022 23:03
@sydney-munro sydney-munro added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2022
@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2022
@sydney-munro sydney-munro merged commit 0bd17b1 into googleapis:main Mar 25, 2022
@release-please release-please bot mentioned this pull request Mar 25, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

3 more reviewers

@dmitry-fa dmitry-fa dmitry-fa approved these changes

@elharo elharo elharo requested changes

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose the methods of Notifications

7 participants

@athakor @dmitry-fa @frankyn @elharo @googlebot @yoshi-kokoro @sydney-munro