Skip to content

fix: Increase delay in test#60

Merged
averikitsch merged 2 commits intomainfrom
ron-gal-patch-1
Jun 24, 2024
Merged

fix: Increase delay in test#60
averikitsch merged 2 commits intomainfrom
ron-gal-patch-1

Conversation

@ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Jun 24, 2024

It seems 10 seconds are not enough time to wait for eventual consistency.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #59 🦕

It seems 10 seconds are not enough time to wait for eventual consistency.
@ron-gal ron-gal requested review from a team June 24, 2024 20:53
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 24, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/langchain-google-bigtable-python API. label Jun 24, 2024
@ron-gal ron-gal changed the title Increase delay in test fix: Increase delay in test Jun 24, 2024
@averikitsch averikitsch merged commit f3ac73a into main Jun 24, 2024
@averikitsch averikitsch deleted the ron-gal-patch-1 branch June 24, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/langchain-google-bigtable-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration tests are failing

2 participants