Skip to content

feat: implement bigtable support for langchain#3

Closed
ron-gal wants to merge 22 commits intomainfrom
implementation
Closed

feat: implement bigtable support for langchain#3
ron-gal wants to merge 22 commits intomainfrom
implementation

Conversation

@ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Jan 23, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ron-gal ron-gal requested a review from a team January 23, 2024 15:55
@ron-gal ron-gal changed the title Initial work feat: implement bigtable support for langchain Jan 23, 2024
@averikitsch
Copy link
Collaborator

averikitsch commented Jan 23, 2024

Hi @ron-gal , can you see if rebase on #7 continues to fix the mypy issue? Thanks!

@averikitsch
Copy link
Collaborator

averikitsch commented Jan 30, 2024

Closing in favor of PRs #6 and #5

@averikitsch averikitsch deleted the implementation branch July 16, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ron-gal @averikitsch