samples: remove old TS conversion script to make way for typeless sample bot#1650
Merged
feywind merged 29 commits intogoogleapis:mainfrom Dec 2, 2022
Merged
samples: remove old TS conversion script to make way for typeless sample bot#1650feywind merged 29 commits intogoogleapis:mainfrom
feywind merged 29 commits intogoogleapis:mainfrom
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
|
Warning: This pull request is touching the following templated files:
|
Collaborator
Author
|
This is waiting now for both an OwlBot image update and another run of the docs-test. |
bcoe
approved these changes
Nov 1, 2022
feywind
added a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Dec 12, 2022
…ple bot (googleapis#1650) * samples: remove old TS conversion script to make way for typeless sample bot * docs: obey incorrect linting about copyright year * build: revert incorrect ci.yaml change * chore: fix lint issues * build: reverse owlboy.py changes for now * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: test gross fix for babel issue in owlbot * build: remove meaningless gitignore * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: test the right samples for TS * chore: bring back tsconfig and update samples readme * build: put converted typescript samples in the right place for system testing * chore: update owlbot * chore: revert owlbot.py changes to the original form * chore: fix broken samples test for commandFor * chore: remove unneeded JS in the TS folder * chore: update owlbot.py with shim to use newest typeless bot * chore: correctly break out command line parameters for testing * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: don't copy non-existent JS samples * build: update owlbot to typeless 1.1.0 image * chore: clean up owlbot.py comments Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the old TS machinery in favour of the new typeless sample bot that is currently under testing.