samples: add more TS samples#1666
Merged
feywind merged 18 commits intogoogleapis:mainfrom Feb 17, 2023
Merged
Conversation
…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport (googleapis#1663) * chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: googleapis/googleapis@758f0d1 Source-Link: googleapis/googleapis-gen@78bd8f0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Megan Potter <57276408+feywind@users.noreply.github.com>
|
Here is the summary of changes. You are about to add 71 region tags.
You are about to delete 35 region tags.
This comment is generated by snippet-bot.
|
|
Warning: This pull request is touching the following templated files:
|
bcoe
suggested changes
Feb 9, 2023
bcoe
left a comment
There was a problem hiding this comment.
Left a couple comments. I think you should be able to simplify OwlBot.py, given that we have typeless sample bot installed already no?
| logger.debug("Update typeless sample bot [1.1.0]") | ||
| shell.run(["npm", "i", "@google-cloud/typeless-sample-bot@1.1.0"]) | ||
| logger.debug("Update typeless sample bot [1.3.0]") | ||
| shell.run(["npm", "i", "@google-cloud/typeless-sample-bot@1.3.0"]) |
There was a problem hiding this comment.
I thought we built @google-cloud/typeless-sample-bot into the post-processor, why is this install necessary?
Collaborator
Author
There was a problem hiding this comment.
Mentioned in Karl's issue on the main bot repo, but I was basically saving review/release time looping through synthtool. It's my intent to get synthtool updated once it's fully stabilized, and I can remove this in another PR.
| # sure quickstart.js gets gts fixed before the README is generated. | ||
| # This needs to be worked out more properly, this is temporary. | ||
| logger.debug("Copy eslint config") | ||
| shell.run( |
There was a problem hiding this comment.
gts should already be built into the container, see:
https://github.com/googleapis/synthtool/blob/master/synthtool/languages/node.py#L216
Which should be called by owlbot_main already.
Collaborator
Author
There was a problem hiding this comment.
Yeah, the trouble is that there's a chicken and egg problem that needs solving here :\ We need to gts fix the quickstart.js before the README gets generated by OwlBot. There are probably better ways to fix this, I'm happy to talk it over :)
There was a problem hiding this comment.
I wonder if we could change the order of operations in synthtool to solve this?
Collaborator
Author
There was a problem hiding this comment.
Mentioned in chat, but recorded here for posterity: because of the README generation step, the quickstart requires a gts pre-pass, but I'll work out how to fix this and come back with a PR removing the manual install and hopefully fixing that.
bcoe
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert more samples to TypeScript, to work with the typeless sample bot.