Skip to content

feat!: node 12 eos (#1774)#1784

Merged
feywind merged 14 commits intomainfrom
node-12-eos
Aug 2, 2023
Merged

feat!: node 12 eos (#1774)#1784
feywind merged 14 commits intomainfrom
node-12-eos

Conversation

@feywind
Copy link
Collaborator

@feywind feywind commented Jul 26, 2023 •
edited
Loading

Fixes #1783 🦕

@feywind
feat!: node 12 eos (#1774) - moving to googleapis
d63d0ca 
* feat!: bring in typing interface for Subscription events

* feat!: gax 4 updates - some of this will be regen'd, just testing
@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 26, 2023
@feywind feywind requested a review from a team as a code owner July 26, 2023 18:48
@feywind feywind requested a review from a team July 26, 2023 18:48
@feywind feywind self-assigned this Jul 26, 2023
@generated-files-bot
Copy link

generated-files-bot bot commented Jul 26, 2023 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/pubsub_perf_bench.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jul 26, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 26, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jul 26, 2023
@feywind feywind added the owlbot:ignore instruct owl-bot to ignore a PR label Jul 26, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 26, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2023
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jul 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@feywind feywind merged commit 47b83c1 into main Aug 2, 2023
@feywind feywind deleted the node-12-eos branch August 2, 2023 17:40
@release-please release-please bot mentioned this pull request Aug 2, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 3, 2023
@release-please
chore(main): release 4.0.0 (#1791)
6c38e7b 
🤖 I have created a release *beep* *boop*
---


## [4.0.0](https://togithub.com/googleapis/nodejs-pubsub/compare/v3.7.3...v4.0.0) (2023-08-03)


### ⚠ BREAKING CHANGES

* node 12 eos ([#1774](https://togithub.com/googleapis/nodejs-pubsub/issues/1774)) (#1784)

### Features

* Node 12 eos ([#1774](https://togithub.com/googleapis/nodejs-pubsub/issues/1774)) ([#1784](https://togithub.com/googleapis/nodejs-pubsub/issues/1784)) ([47b83c1](https://togithub.com/googleapis/nodejs-pubsub/commit/47b83c18c543a7c8763256f79927a7340db56568))


### Bug Fixes

* Fix typings for IAM methods ([#1785](https://togithub.com/googleapis/nodejs-pubsub/issues/1785)) ([9a6bdbc](https://togithub.com/googleapis/nodejs-pubsub/commit/9a6bdbce952c81cb1a43fecbce16a3e3ab0f1420))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feywind feywind

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

End of support for Node 12

4 participants

@feywind @alexander-fenster @yoshi-kokoro @renovate-bot