Skip to content

fix: Do not set customEndpoint if apiEndpoint === default#2460

Merged
danielbankhead merged 1 commit intomainfrom
api-endpoint-check
May 8, 2024
Merged

fix: Do not set customEndpoint if apiEndpoint === default#2460
danielbankhead merged 1 commit intomainfrom
api-endpoint-check

Conversation

@danielbankhead
Copy link
Contributor

🦕

@danielbankhead danielbankhead requested a review from a team as a code owner May 7, 2024 21:55
@danielbankhead danielbankhead requested a review from a team May 7, 2024 21:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 7, 2024
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was there an associated problem with this?

@danielbankhead
Copy link
Contributor Author

LGTM. Was there an associated problem with this?

Nope! I think it would be a minor, but useful feature for universeDomain users

@danielbankhead danielbankhead merged commit b4dbd73 into main May 8, 2024
@danielbankhead danielbankhead deleted the api-endpoint-check branch May 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants