feat: Add support for SDK Method metrics tracking via _USER_AGENT_SDK…#1591
Merged
SinaChavoshi merged 7 commits intogoogleapis:mainfrom Aug 17, 2022
Merged
Conversation
jialuzh
approved these changes
Aug 15, 2022
sararob
requested changes
Aug 16, 2022
Contributor
sararob
left a comment
There was a problem hiding this comment.
Thanks for adding this! Left a few comments. Before we submit this, is there a way to test that these method calls are getting added to a dashboard in the way we're expecting?
sararob
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_COMMAND
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕