fix: Error when only log confusion matrix or ROC curve through log_classification_metrics#1742
Merged
jaycee-li merged 1 commit intogoogleapis:mainfrom Oct 20, 2022
Conversation
sasha-gitg
approved these changes
Oct 19, 2022
Member
sasha-gitg
left a comment
There was a problem hiding this comment.
Preference to add unit tests that test:
- Passing just labels and metrics
- Passing just fpr,tpr,and threshold
Can be added in a follow up PR to unblock this fix.
jialuzh
approved these changes
Oct 20, 2022
Contributor
jialuzh
left a comment
There was a problem hiding this comment.
+1, let's add some tests to cover this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
get error
local variable 'confidence_metrics' referenced before assignmentif users only log confusion matrix through
log_classification_metrics