feat: Made display_name parameter optional for most calls#882
Merged
gcf-merge-on-green[bot] merged 23 commits intogoogleapis:mainfrom Apr 5, 2022
Merged
Conversation
2508d11 to
ae8adcb
Compare
sasha-gitg
requested changes
Jan 19, 2022
Member
sasha-gitg
left a comment
There was a problem hiding this comment.
Please add/update unit tests to test this change.
bf9f73f to
fabb496
Compare
Contributor
Author
|
I think I've resolved all feedback. |
de0b11f to
f08c19b
Compare
Contributor
Author
|
What are the remaining action items for me here? |
Contributor
|
Re-assigning @sasha-gitg for triage. @Ark-kun the change of argument order in public methods is considered a breaking change and cannot be merged. Some Vertex AI resources require display_name (i.e. all the Job subclasses). Please work with the team to address these issues, thanks! |
Contributor
Author
Thank you for the link. I've missed this one. I'll restore the ordering. Thank you. |
The parameter default values had to be removed due to Python's syntax.
40dac14 to
00977be
Compare
sasha-gitg
requested changes
Mar 7, 2022
45d8e14 to
b1b19f7
Compare
…ns where default value cannot be specified
b1b19f7 to
fee7b89
Compare
kweinmeister
approved these changes
Apr 5, 2022
sasha-gitg
approved these changes
Apr 5, 2022
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
… - Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…- Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
… - Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
Ark-kun
added a commit
to Ark-kun/pipeline_components
that referenced
this pull request
Aug 1, 2022
…- Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #853 🦕