chore: Check in service proto file#1174
Merged
ivanmkc merged 2 commits intogoogleapis:mainfrom May 11, 2022
Merged
Conversation
Contributor
|
The proto looks good but what was the rationale to not just add a match method for |
Contributor
Author
|
Match is a method of MatchService, not IndexEndpointService. I assume that means it should not be part of IndexEndpointServiceClient? |
Contributor
|
Sorry, I mean MatchService. Will there be a GAPIC version of MatchService? |
Contributor
Author
|
This is a short term solution to make it easy for clients to generate their own library. We are looking into options to publish GAPICs in the long run. |
Contributor
|
As discussed, please move to the _proto folder after #1192 is merged. |
Contributor
|
Hi @yan283, the matching engine PR is merged so you can move the proto to the google/cloud/aiplatform/matching_engine/_protos folder. |
4d48aa4 to
82f0584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1173 🦕