feat: Migrate sample and sample tests - Batch 3 of 5#13
Merged
dizcology merged 19 commits intosample-final-stagefrom Nov 11, 2020
Merged
feat: Migrate sample and sample tests - Batch 3 of 5#13dizcology merged 19 commits intosample-final-stagefrom
dizcology merged 19 commits intosample-final-stagefrom
Conversation
338b99d to
043ae58
Compare
kurtisvg
suggested changes
Sep 26, 2020
043ae58 to
2f373d9
Compare
Contributor
|
The usual flow is to merge to the main branch and then cut the release PR. Is it possible to change the branch you are merging into to @dizcology This is likely also the the samples presubmit is missing. The kokoro configs added in #16 aren't present in the |
kurtisvg
suggested changes
Oct 2, 2020
kurtisvg
suggested changes
Nov 9, 2020
kurtisvg
left a comment
There was a problem hiding this comment.
I've copy/pasted several comments from previous reviews that weren't addressed.
kurtisvg
reviewed
Nov 10, 2020
kurtisvg
suggested changes
Nov 10, 2020
kurtisvg
approved these changes
Nov 11, 2020
|
Please include the issue number for tracking the outstanding work before submitting. |
dizcology
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #9 (Batch 3 of 5) 🦕
Github issues raised by this PR: #51 , #52