chore: system test for model monitoring#1428
Merged
rosiezou merged 7 commits intomodel-monitoringfrom Jun 28, 2022
Merged
Conversation
97322c2 to
db20a04
Compare
99987d3 to
ee05588
Compare
ee05588 to
99987d3
Compare
Contributor
Author
|
@dandhlee @googleapis/yoshi-python please ignore the review request for this PR. It was auto-generated due to a botched rebase which I have fixed. |
62253e3 to
7e373c9
Compare
Contributor
Author
|
merging this branch into the parent branch for easier review |
rosiezou
added a commit
that referenced
this pull request
Jul 28, 2022
* feat: SDK support for model monitoring (for models deployed to endpoints; batch prediction use case will be implemented separately)" * fixing syntax errors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * resolving merge diff * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removing sync parameter from MDM job * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing runtime errors * fixing more runtime errors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing some more linter errors * added endpoint path resolution logic * excluding uninitialized optional arguments for as_proto methods in objective config * fixing typo in class variable * adding more upstream error handling * fixing errors with runtime type checks * fixed runtime errors in update and pause functions * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removing unused methods * fixed job delete method * removing unused parameter * addressing some PR comments * docs clarification * Update google/cloud/aiplatform/jobs.py Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * Update google/cloud/aiplatform/jobs.py Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * Update google/cloud/aiplatform/jobs.py Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com> * fixing logic for checking explanation_specs * chore: system test for model monitoring (#1428) * chore: adding system test for model monitoring * debugged system test * removing extra print statements * added test coverage for pause resume and delete methods * added test coverage for model monitoring config for two models * fixing test bug * added test coverage for XAI error case * addressed more PR comments * addressing remaining comments * adding more error checking in parse_configs helper function * minor fix for deployed model ID validation logic * addressing docs commentes * addressed more PR comments * removing runtime errors * added more documentation * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * addressing PR comments * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * addressing more PR comments * adding more doc strings * more fixes * formatting * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * added more test coverage and changed iterator names for parse_configs function * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * making objective config class non-abstract * renaming configuration classes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕