Feat: Add google.ClassificationMetrics, google.RegressionMetrics, and google.Forecasting Metrics#1549
Merged
jaycee-li merged 11 commits intogoogleapis:mainfrom Aug 2, 2022
KevinBNaughton:main
Merged
Feat: Add google.ClassificationMetrics, google.RegressionMetrics, and google.Forecasting Metrics#1549jaycee-li merged 11 commits intogoogleapis:mainfrom KevinBNaughton:main
jaycee-li merged 11 commits intogoogleapis:mainfrom
KevinBNaughton:main
Conversation
…e.ForecastingMetrics Artifact types to metadata schema with unit tests.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
SinaChavoshi
requested changes
Jul 28, 2022
Member
SinaChavoshi
left a comment
There was a problem hiding this comment.
Thank you for the PR! looks great I only had a minor comment.
google/cloud/aiplatform/metadata/schema/google/artifact_schema.py
Outdated
Show resolved
Hide resolved
|
PUBG MAILE |
SinaChavoshi
approved these changes
Jul 28, 2022
Member
SinaChavoshi
left a comment
There was a problem hiding this comment.
Nice work! Thank you for the PR!
Member
|
I believe the error is a lint issue, two files need to be reformatted. You can run |
jaycee-li
requested changes
Aug 1, 2022
jaycee-li
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: Add google.ClassificationMetrics, google.RegressionMetrics, and google.Forecasting Metrics