feat: code snippets for feature store control plane#709
Merged
lclc19 merged 4 commits intogoogleapis:mainfrom Sep 22, 2021
Merged
feat: code snippets for feature store control plane#709lclc19 merged 4 commits intogoogleapis:mainfrom
lclc19 merged 4 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
5ce50af to
cfc2ff9
Compare
morgandu
previously requested changes
Sep 15, 2021
Contributor
morgandu
left a comment
There was a problem hiding this comment.
Thanks for the samples, left a few comments, also, the delete sample need a testing too.
samples/snippets/feature_store_service/create_entity_type_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/delete_featurestore_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/create_featurestore_sample_test.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/create_entity_type_sample_test.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/create_feature_sample_test.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
For delete sample, I see that dataset_service only has the sample file, and no test for delete sample was provided: I wonder if this is intentional as the teardown procedure already has the deletion snippets. |
678e868 to
0c84871
Compare
Contributor
Author
|
Anyways, I've added delete featurestore test |
0c84871 to
27a15d5
Compare
* Add resource creation and deletion including featurestore, entity type and feature.
27a15d5 to
4d8e39d
Compare
morgandu@ is OOO and lclc@ has addressed all requested changes, lifting blocking review.
vinnysenthil
approved these changes
Sep 22, 2021
Contributor
vinnysenthil
left a comment
There was a problem hiding this comment.
LGTM - @morgandu's requested changes have been addressed, tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.