fix: Add More Specific Type Annotations for Row Dictionaries#1295
Merged
parthea merged 4 commits intogoogleapis:mainfrom Nov 16, 2022
Merged
fix: Add More Specific Type Annotations for Row Dictionaries#1295parthea merged 4 commits intogoogleapis:mainfrom
parthea merged 4 commits intogoogleapis:mainfrom
Conversation
686ba40 to
70c643e
Compare
70c643e to
ec97e77
Compare
The keys must be strings as they represent column names. Update type annotations to reflect this.
ec97e77 to
0468067
Compare
Contributor
|
@chalmerlowe Please could you take a look? |
Contributor
|
@parthea sorry for the delay. I reviewed/tested this and it was all good! |
aribray
approved these changes
Nov 15, 2022
This was referenced Nov 22, 2022
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…apis#1295) The keys must be strings as they represent column names. Update type annotations to reflect this. Co-authored-by: aribray <45905583+aribray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
annotations to reflect this.