docs: Updates query to query and wait in samples/client_query_w_timestamp_params.py#1785
Merged
tswast merged 6 commits intogoogleapis:mainfrom Jan 26, 2024
Merged
docs: Updates query to query and wait in samples/client_query_w_timestamp_params.py#1785tswast merged 6 commits intogoogleapis:mainfrom
tswast merged 6 commits intogoogleapis:mainfrom
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
tswast
requested changes
Jan 25, 2024
| query, job_config=job_config | ||
| ) # Make an API request. | ||
|
|
||
| for row in query_job: |
Contributor
There was a problem hiding this comment.
Please rename this line too.
Suggested change
| for row in query_job: | |
| for row in results: |
Contributor
Author
There was a problem hiding this comment.
Yes, I will rename this one.
tswast
approved these changes
Jan 25, 2024
This was referenced Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕