feat(bigquery): add __eq__ method for class PartitionRange and RangePartitioning#162
Merged
plamut merged 4 commits intogoogleapis:masterfrom Jul 13, 2020
Merged
Conversation
…into bigquery_issue_159
plamut
suggested changes
Jul 10, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
Mutable objects should not advertise themselves as hashable, otherwise looks good.
plamut
reviewed
Jul 13, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
Looks good, I would just change the hashability assertions to a more explicit form rather than testing the "implementation detail".
Contributor
|
Great! Thank you @HemangChothani |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159