test: update the results of test based on change to hacker news data#1949
Merged
test: update the results of test based on change to hacker news data#1949
Conversation
Linchin
reviewed
Jun 12, 2024
Linchin
approved these changes
Jun 12, 2024
Contributor
Linchin
left a comment
There was a problem hiding this comment.
Thanks for fixing the sys test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests were failing. presubmit testing. This PR updates the expected results to match the fetched results.
The reason for the problem is because we updated the online version of the hacker-news data dump and the data changed slightly. This now matches the data dump.