refactor: restructing instrumentation format#244
Conversation
|
Nit on commit name: |
| name=span_name, attributes=span_attributes, client=self, job_ref=job_ref | ||
| ): | ||
| return call() | ||
| return call() |
There was a problem hiding this comment.
Could you add a unit test just for _call_api itself to check this code branch? It can verify that create_span is not called if span_name is not specified.
Edit: and maybe check that call() or self._connection.api_request is called exactly once.
There was a problem hiding this comment.
test's added in test_client.py seen on line 253 -> 299
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Reformatting instrumentation to a cleaner implementation.
Fixes #245 🦕