Skip to content

feat: support Series.dt.strftime#453

Merged
junyazhang merged 5 commits intomainfrom
lily_strftime
Mar 18, 2024
Merged

feat: support Series.dt.strftime#453
junyazhang merged 5 commits intomainfrom
lily_strftime

Conversation

@junyazhang
Copy link
Contributor

Fixes internal bug: b/309817430 🦕

Staged doc: https://screenshot.googleplex.com/aYkRZJjm2ehx8E6

@junyazhang junyazhang requested a review from a team as a code owner March 15, 2024 23:29
@junyazhang junyazhang requested review from a team and chelsea-lin March 15, 2024 23:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 15, 2024
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@junyazhang junyazhang merged commit 8f6e955 into main Mar 18, 2024
@junyazhang junyazhang deleted the lily_strftime branch March 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants