feat: support dataframe.cov#498
Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom Mar 22, 2024
Merged
Conversation
Contributor
|
chelsea-lin
reviewed
Mar 22, 2024
bigframes/core/blocks.py
Outdated
| """ | ||
| if len(self.value_columns) > 30: | ||
| raise NotImplementedError( | ||
| f"Only work with dataframes containing fewer than 30 columns. Current: {len(self.columns)}. {constants.FEEDBACK_LINK}" |
Contributor
There was a problem hiding this comment.
please help to double check if error message matches with the code? Does "fewer than 30 columns" include 30?
chelsea-lin
approved these changes
Mar 22, 2024
Contributor
chelsea-lin
left a comment
There was a problem hiding this comment.
Minor comments. Overall LGTM
|
|
||
| def cov(self, *, numeric_only: bool = False) -> DataFrame: | ||
| if not numeric_only: | ||
| frame = self._raise_on_non_numeric("corr") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Document:
https://screenshot.googleplex.com/9egi7MsNj2uWHkH
Fixes #<issue_number_goes_here> 🦕