Skip to content

feat: allow functions returned from bpd.read_gbq_function to execute outside of apply#706

Merged
tswast merged 20 commits intomainfrom
tswast-read_gbq_function-local-testing
Jun 4, 2024
Merged

feat: allow functions returned from bpd.read_gbq_function to execute outside of apply#706
tswast merged 20 commits intomainfrom
tswast-read_gbq_function-local-testing

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented May 17, 2024 •
edited
Loading

Tested manually:

import bigframes.pandas as bpd

func = bpd.read_gbq_function("bqutil.fn.cw_lower_case_ascii_only")
func("AURÉLIE")
# Out[3]: 'aurÉlie'

TODO

🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 17, 2024
tswast added 11 commits May 20, 2024 15:18
@tswast
Merge remote-tracking branch 'origin/main' into tswast-remote-functio…
9a3170c 
…n-local-testing
@tswast
fix for rare case where re-deploy exact same function object
cc11de5
@tswast
Merge branch 'main' into tswast-remote-function-local-testing
05724b3
@tswast
feat: support type annotations to supply input and output types to `@…
395b9ee 
…remote_function` decorator
@tswast
Merge branch 'main' into b336023152-remote_function-type-annotations
41f10a0
@tswast
Merge branch 'main' into tswast-remote-function-local-testing
c31d2d4
@tswast
Merge remote-tracking branch 'origin/main' into b336023152-remote_fun…
1869aba 
…ction-type-annotations
@tswast
make tests robust to cloud function listing failures too
1cf934e
@tswast
Merge remote-tracking branch 'origin/b336023152-remote_function-type-…
59da6f4 
…annotations' into b336023152-remote_function-type-annotations
@tswast
Merge remote-tracking branch 'origin/main' into b336023152-remote_fun…
740c7a0 
…ction-type-annotations
@tswast
Merge branch 'b336023152-remote_function-type-annotations' into tswas…
682afed 
…t-read_gbq_function-local-testing
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 24, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 25, 2024
@tswast tswast marked this pull request as ready for review May 30, 2024 14:52
@tswast tswast requested a review from a team as a code owner May 30, 2024 14:52
@tswast tswast requested review from a team and TrevorBergeron May 30, 2024 14:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 30, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 30, 2024
tswast
tswast commented May 30, 2024
View reviewed changes
bigframes/functions/remote_function.py
Read an existing BigQuery function and prepare it for use in future queries.
"""

# A BigQuery client is required to perform BQ operations
Copy link
Contributor Author

@tswast tswast May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of system tests, there weren't any code paths that passed in bigquery_client but not session, so removing this unnecessary logic.

@tswast tswast merged commit ad7d8ac into main Jun 4, 2024
@tswast tswast deleted the tswast-read_gbq_function-local-testing branch June 4, 2024 19:00
@release-please release-please bot mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@milkshakeiii milkshakeiii

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @TrevorBergeron @milkshakeiii