Skip to content

feat: add DataFrame.to_arrow to create Arrow Table from DataFrame#807

Merged
tswast merged 9 commits intomainfrom
issue735-to_arrow-for-polars
Jun 27, 2024
Merged

feat: add DataFrame.to_arrow to create Arrow Table from DataFrame#807
tswast merged 9 commits intomainfrom
issue735-to_arrow-for-polars

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Jun 26, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #735 🦕

@tswast tswast requested a review from a team as a code owner June 26, 2024 21:18
@tswast tswast requested a review from a team June 26, 2024 21:18
@tswast tswast requested a review from a team as a code owner June 26, 2024 21:18
@snippet-bot
Copy link

snippet-bot bot commented Jun 26, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Jun 26, 2024
@tswast tswast mentioned this pull request Jun 26, 2024
Closed
@tswast tswast requested review from chelsea-lin and removed request for milkshakeiii June 27, 2024 15:41
@tswast tswast assigned chelsea-lin and unassigned junyazhang Jun 27, 2024
chelsea-lin
chelsea-lin approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samples/polars/noxfile.py
@@ -0,0 +1,292 @@
# Copyright 2019 Google LLC
Copy link
Contributor

@chelsea-lin chelsea-lin Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file auto generated from a template? If not, can we update the copyright year to 2024? Also check other new files too?

Copy link
Contributor Author

@tswast tswast Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is templated, so not much we can do.

samples/polars/create_polars_df_with_to_arrow_test.py Outdated
polars_df = polars.from_arrow(arrow_table)
# [END bigquery_dataframes_to_polars]

assert polars_df is not None
Copy link
Contributor

@chelsea-lin chelsea-lin Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assert polars_df is equal to bf_df? Or maybe there are some diverse?

Copy link
Contributor Author

@tswast tswast Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could possibly compare shapes or some aggregate values. I'll give it a try.

@tswast tswast enabled auto-merge (squash) June 27, 2024 22:08
@tswast tswast merged commit 1e3feda into main Jun 27, 2024
@tswast tswast deleted the issue735-to_arrow-for-polars branch June 27, 2024 23:07
@release-please release-please bot mentioned this pull request Jun 27, 2024
Merged
@tswast tswast mentioned this pull request Jul 18, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@polong-lin polong-lin Awaiting requested review from polong-lin polong-lin is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @chelsea-lin @junyazhang