Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

fix: require python 3.7+#284

Merged
parthea merged 5 commits intomainfrom
owl-bot-update-lock-e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c
Jul 10, 2022
Merged

fix: require python 3.7+#284
parthea merged 5 commits intomainfrom
owl-bot-update-lock-e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jul 5, 2022

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

@gcf-owl-bot
chore(python): drop python 3.6
eebac8f 
Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 5, 2022 18:36
@gcf-owl-bot gcf-owl-bot bot requested a review from a team July 5, 2022 18:36
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 5, 2022 18:36
@gcf-owl-bot gcf-owl-bot bot requested review from leahecole and shollyman July 5, 2022 18:36
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 5, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigqueryreservation Issues related to the googleapis/python-bigquery-reservation API. labels Jul 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2022
@parthea parthea changed the title chore(python): drop python 3.6 fix: require python 3.7+ Jul 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2022
@shollyman
Copy link
Contributor

shollyman commented Jul 7, 2022

prerelease failure doesn't seem to find the system test.

nox > py.test tests/system
============================= test session starts ==============================
platform linux -- Python 3.8.12, pytest-7.1.2, pluggy-1.0.0
rootdir: /tmpfs/src/github/python-bigquery-reservation
plugins: asyncio-0.18.3, cov-3.0.0
asyncio: mode=legacy
collected 0 items

=============================== warnings summary ===============================
.nox/prerelease_deps-3-8/lib/python3.8/site-packages/pytest_asyncio/plugin.py:191
  /tmpfs/src/github/python-bigquery-reservation/.nox/prerelease_deps-3-8/lib/python3.8/site-packages/pytest_asyncio/plugin.py:191: DeprecationWarning: The 'asyncio_mode' default value will change to 'strict' in future, please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration file.
    config.issue_config_time_warning(LEGACY_MODE, stacklevel=2)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================== 1 warning in 0.01s ==============================
ERROR: file or directory not found: tests/system

nox > Command py.test tests/system failed with exit code 4
nox > Session prerelease_deps-3.8 failed.
cleanup

@shollyman shollyman requested review from loferris and removed request for shollyman July 8, 2022 20:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2022
@parthea parthea merged commit 13c0983 into main Jul 10, 2022
@parthea parthea deleted the owl-bot-update-lock-e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c branch July 10, 2022 17:27
@release-please release-please bot mentioned this pull request Jul 10, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leahecole leahecole Awaiting requested review from leahecole leahecole was automatically assigned from googleapis/python-samples-reviewers

@loferris loferris Awaiting requested review from loferris

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryreservation Issues related to the googleapis/python-bigquery-reservation API. owl-bot-update-lock size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shollyman @parthea @yoshi-kokoro