docs(samples): Adding samples for image creation and deletion#270
docs(samples): Adding samples for image creation and deletion#270m-strzelczyk merged 10 commits intomainfrom
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
parthea
left a comment
There was a problem hiding this comment.
Added minor observations
samples/ingredients/images/create.py
Outdated
| if not force_create: | ||
| raise RuntimeError(f"Instance {disk_user} should be stopped. Please stop the instance using " | ||
| f"GCESysprep command or set forceCreate parameter to true (not recommended). " | ||
| f"More information here: https://cloud.google.com/compute/docs/instances/windows/creating-windows-os-image#api.") |
There was a problem hiding this comment.
Is the instance always a windows instance or can it be a different OS?
There was a problem hiding this comment.
Actually, you are right, this comment should specify what to do for Windows and what to do for Linux instances. Linux doesn't have GCESysprep, but should still be shut down before image creation. I'll update the message.
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Samples to create and delete images. The
compute_windows_image_createregion is here to match https://github.com/googleapis/nodejs-compute/pull/703/files