Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

tests: add system tests for python-compute#34

Merged
arithmetic1728 merged 7 commits intogoogleapis:masterfrom
georgiyekkert:master
Mar 30, 2021
Merged

tests: add system tests for python-compute#34
arithmetic1728 merged 7 commits intogoogleapis:masterfrom
georgiyekkert:master

Conversation

@georgiyekkert
Copy link
Contributor

@georgiyekkert georgiyekkert commented Mar 25, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@georgiyekkert georgiyekkert requested a review from a team as a code owner March 25, 2021 17:46
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Mar 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
@georgiyekkert georgiyekkert changed the title tests: add system tests for python-compute tests: add system tests for python-compute Mar 25, 2021
@arithmetic1728
Copy link
Contributor

arithmetic1728 commented Mar 30, 2021

@georgiyekkert could you remove the tests/test_system.py as well? It is just a dummy test for testing mtls before, now it is no longer needed.

@arithmetic1728 arithmetic1728 merged commit a97482f into googleapis:master Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgiyekkert @arithmetic1728