Skip to content

chore: add jdk 8 verification to showcase CI#3735

Merged
mpeddada1 merged 9 commits intomainfrom
jdk8-showcase
May 5, 2025
Merged

chore: add jdk 8 verification to showcase CI#3735
mpeddada1 merged 9 commits intomainfrom
jdk8-showcase

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Apr 8, 2025 •
edited
Loading

This PR adds showcase testing for JDK 8.

Error:    bad class file: /home/runner/.m2/repository/ch/qos/logback/logback-classic/1.5.16/logback-classic-1.5.16.jar(ch/qos/logback/classic/Level.class)
Error:      class file has wrong version 55.0, should be 52.0

According to https://logback.qos.ch/dependencies.html 1.5.x targets at least JDK 11.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 8, 2025
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Apr 8, 2025

Adding 8 to the matrix results in:

Failed to execute goal com.spotify.fmt:fmt-maven-plugin:2.25:check (default) on project api-common: Execution default of goal com.spotify.fmt:fmt-maven-plugin:2.25:check failed: Unable to load the mojo 'check' in the plugin 'com.spotify.fmt:fmt-maven-plugin:2.25' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: com/spotify/fmt/Check has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 11, 2025
@mpeddada1 mpeddada1 requested a review from blakeli0 April 11, 2025 19:21
@mpeddada1 mpeddada1 marked this pull request as ready for review April 11, 2025 19:22
blakeli0
blakeli0 reviewed Apr 21, 2025
View reviewed changes
@mpeddada1 mpeddada1 requested a review from blakeli0 May 2, 2025 21:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mpeddada1 mpeddada1 merged commit c2ab582 into main May 5, 2025
70 of 73 checks passed
@mpeddada1 mpeddada1 deleted the jdk8-showcase branch May 5, 2025 20:50
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
@mpeddada1 @lqiu96
chore: add jdk 8 verification to showcase CI (#3735)
974cfda
lqiu96 pushed a commit that referenced this pull request Aug 21, 2025
@mpeddada1 @lqiu96
chore: add jdk 8 verification to showcase CI (#3735)
cf4b7e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @blakeli0