Open
Conversation
…_old, also removed subscribe from FOLDER method
Member
|
Thanks! |
Member
gilleslamiral
left a comment
There was a problem hiding this comment.
The call to subscribe has also to be made where it used to be since subscribed folders synchronization is something independent of folder creation. You want to subscribe folders even if they already exist.
(maybe I misread your patch, tell me)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug when using subscribeall and subfolder2 args together. The parent(subfolder2) was not subscribed, only the children folders. So I created "sub" called subscribe to folder, which is called after a folder is created and subscribe is neccessary..