Skip to content

Cleanup: test instrumentation dependency prometheus#137313

Open
tico88612 wants to merge 2 commits intokubernetes:masterfrom
tico88612:cleanup/test-instrumentation-dep-prometheus
Open

Cleanup: test instrumentation dependency prometheus#137313
tico88612 wants to merge 2 commits intokubernetes:masterfrom
tico88612:cleanup/test-instrumentation-dep-prometheus

Conversation

@tico88612
Copy link
Member

@tico88612 tico88612 commented Feb 28, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove dependency Prometheus from test/integration/metrics/metrics_test.go and test/instrumentation/main_test.go

Which issue(s) this PR is related to:

Related #89267

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@tico88612
Remove dep. Prometheus from test/integration/metrics/metrics_test.go
e171c90 
Add LabelValues in component-base/metric

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Remove dep. Prometheus from test/instrumentation/main_test.go
35df7ce 
This is not directly import but will warning in
verify-prometheus-imports.sh

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 28, 2026

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 28, 2026
@k8s-ci-robot k8s-ci-robot added area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 28, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 28, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Instrumentation Feb 28, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tico88612
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango, soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@pohly pohly Awaiting requested review from pohly

Assignees

No one assigned

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Instrumentation
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tico88612 @k8s-ci-robot