prevent mapper generation from type with generic super bound to type with generic extends bound#3994
Open
hduelme wants to merge 1 commit intomapstruct:mainfrom
Conversation
…with generic extends bound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, MapStruct generates code that attempts to implicitly cast a
Collection<? super Type>toTypeinside theforloop. This is not valid, since the elements of the collection are not guaranteed to be instances of Type, which results in a compilation error.The same issue applies to Stream.
I changed the behavior so that mappings from
Collection<? super Type>toCollection<? extends Type>and fromStream<? super Type>toStream<? extends Type>now result inPROPERTYMAPPING_MAPPING_NOT_FOUND.Additionally, I added a test to verify that mapping from
Collection<? extends Type>toCollection<? super Type>works correctly. I did not add a corresponding test for Stream, since it currently generates invalid code (it tries to directly assignCollection<? extends Type>toCollection<Type>).I am unsure what the correct behavior should be in this case, Currently, MapStruct generates code that attempts to implicitly cast a
Collection<? super Type>toTypeinside theforloop. This is not valid, since the elements of the collection are not guaranteed to be instances of Type, which results in a compilation error.The same issue applies to Stream.
I changed the behavior so that mappings from
Collection<? super Type>toCollection<? extends Type>and fromStream<? super Type>toStream<? extends Type>now result inPROPERTYMAPPING_MAPPING_NOT_FOUND.Additionally, I added a test to verify that mapping from
Collection<? extends Type>toCollection<? super Type>works correctly. I did not add a corresponding test for Stream, since it currently generates invalid code (it tries to directly assignCollection<? extends Type>toCollection<Type>).I am unsure what the correct behavior should be in this case, as MapStruct currently doesn't fully supports type bonds: