Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates several GitHub Actions workflow files to improve security, standardize Azure authentication, and simplify deployment configuration. The main changes include switching from manual Azure CLI login to the
azure/login@v2action, removing redundant secrets, consolidating Linux and Windows deployment workflows, and adding support for dynamic runner selection.Authentication and Security Improvements
azure/login@v2GitHub Action in.github/workflows/ci.yml,.github/workflows/docker-build-and-push.yml, and other workflows, making authentication more secure and maintainable. [1] [2] [3]id-token: writepermission to workflows to support OIDC-based authentication for Azure, improving security posture. [1] [2] [3]Workflow Configuration and Environment Standardization
environment: productionfor key jobs in CI, Docker build, and cleanup workflows to ensure consistent environment context for deployments. [1] [2] [3] [4]Deployment Workflow Simplification
.github/workflows/deploy-windows.ymland renaming.github/workflows/deploy-linux.ymlto.github/workflows/deploy-v2.yml, streamlining deployment logic. [1] [2]runner_osinput to the deployment workflow, allowing dynamic selection betweenubuntu-latestandwindows-latestrunners based on user input, and propagated this through workflow outputs and orchestrator calls. [1] [2] [3] [4] [5] [6]Workflow Permissions Cleanup
permissionsblocks from workflow orchestrator and cleanup jobs, relying on centralized permissions management. [1] [2]These updates make the workflows more secure, flexible, and easier to maintain, particularly around Azure authentication and deployment environment selection.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information