chore: add failing test for findOne by entity with composite PK's & FK's#5675
chore: add failing test for findOne by entity with composite PK's & FK's#5675russell-dot-js wants to merge 12 commits intomikro-orm:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5675 +/- ##
========================================
Coverage 99.74% 99.74%
========================================
Files 261 261
Lines 18121 18121
Branches 3888 4436 +548
========================================
Hits 18074 18074
Misses 47 47 ☔ View full report in Codecov by Sentry. |
|
can you adjust the PR title and description? it should reflect what the PR is doing since it dictates the commit message |
sorry, having a little bit of a brain fart. the PR title says I added a failing test for findOne, code looks like it's doing that, what am I missing |
|
oh its just a repro, i though its like the other PR where you also had the exact same PR title, tests were green and it was because you actually fixed that already |
results in mismatch between selected fields and value tuples, see this comment