Add format to the docker system df command#31482
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 13, 2017
boaz0:add_format_to_system_df
Merged
Add format to the docker system df command#31482thaJeztah merged 1 commit intomoby:masterfrom boaz0:add_format_to_system_df
thaJeztah merged 1 commit intomoby:masterfrom
boaz0:add_format_to_system_df
Conversation
24 tasks
vdemeester
reviewed
Mar 31, 2017
Member
vdemeester
left a comment
There was a problem hiding this comment.
Design SGTM
/cc @thaJeztah @dnephin @mlaventure
vdemeester
approved these changes
Apr 3, 2017
Member
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐯
/cc @thaJeztah for docs-review
@ripcurld0 You will need to updates docs I think 👼
Contributor
Author
|
Yes I will. |
Contributor
Author
|
DONE 😀 🎸 @thaJeztah |
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
AkihiroSuda
reviewed
Apr 12, 2017
| <Paste> | ||
| ``` | ||
|
|
||
| **Note** the format option is meaningless when verbose is true. |
Contributor
Author
There was a problem hiding this comment.
Yep, we can. I will do that soon.
Member
There was a problem hiding this comment.
Perhaps;
> **Note**: the format option is ignored if `--verbose` is usedHowever, since you're planning to do a follow up to error out, let's keep it for now (you can remove it in that PR)
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Add format to the docker system df command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add the format option to the docker-system-df command
related to #30431
- How I did it
- How to verify it
TESTDIRS='cli/command/formatter/' TESTFLAGS='-test.run ^TestDiskUsage*' hack/make.sh test-unit- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
todo: add to docs