Skip to content

Move "labels" to compose 3.3 format#32972

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:compose-move-labels-to-3.3
May 5, 2017
Merged

Move "labels" to compose 3.3 format#32972
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:compose-move-labels-to-3.3

Conversation

@thaJeztah
Copy link
Member

Commit bb5dfdb (#32632) added a labels option to the docker-compose file format, but added it to the 3.2 schema.

This patch moves the change to the 3.3 schema

This should go in after #32743 was merged (and will have to be rebased then)

Commit bb5dfdb added a
labels option to the docker-compose file format, but
added it to the 3.2 schema.

This patch moves the change to the 3.3 schema

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vieux
Copy link
Contributor

vieux commented May 3, 2017

ping @dnephin

@dnephin
Copy link
Member

dnephin commented May 3, 2017

LGTM

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@cpuguy83 cpuguy83 merged commit 4662d3e into moby:master May 5, 2017
@thaJeztah thaJeztah deleted the compose-move-labels-to-3.3 branch May 5, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants