Fix run docker rename <container-id> new_name concurrently, the container will have multi names#33940
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Jul 7, 2017
Merged
Conversation
Member
|
cc @cpuguy83 @fabiokung PTAL? |
0273b4b to
cc23406
Compare
…tainer will have multi names When run `docker rename <container-id> new_name` concurrently, every operation will release container's old name. So container will have multi new names reserve in nameIndex. Signed-off-by: Yang Pengfei <yangpengfei4@huawei.com>
Contributor
Author
|
@fabiokung PTAL |
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run
docker rename <container-id> new_nameconcurrently, every operation will release oldcontainer name. So container will have multi new names reserve in nameIndex.
- What I did
Fix a bug:
Description:
docker run busyboxdocker renamecommand concurrentlydocker psanddocker inspect, container name is different- How I did it
Every
docker renameoperation should release newest container name, so container should get locked before get container name.- How to verify it
docker renamecommand concurrentlydocker psanddocker inspect, container name is the sameSigned-off-by: Yang Pengfei yangpengfei4@huawei.com