Windows: Remove servicing mode#36267
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 28, 2018
Merged
Conversation
65257b3 to
58c1ba4
Compare
Signed-off-by: John Howard <jhoward@microsoft.com>
58c1ba4 to
d4f37c0
Compare
Member
Author
|
Rebased |
Member
Author
|
ping @darrenstahlmsft now you're back :) |
Codecov Report
@@ Coverage Diff @@
## master #36267 +/- ##
=========================================
Coverage ? 34.69%
=========================================
Files ? 611
Lines ? 45286
Branches ? 0
=========================================
Hits ? 15711
Misses ? 27512
Partials ? 2063 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Removes servicing mode for Windows containers. In RS1-RS3, this actually never worked and was never triggered by the platform. In RS4, cupdate was removed from the image so is never triggered. Hence removing redundant code.
@darrenstahlmsft @johnstep PTAL. (Note once merged, I'll remove the remaining pieces from HCSShim and revendor it. Just some sequencing needed).
@swernli FYI :)