Frozen busybox latest glibc by arm64b · Pull Request #36375 · moby/moby

arm64b · 2018-02-22T07:08:26Z

As the follow-up of PR #36298, this PR:

Adding both busybox:latest and busybox:glibc into docker container as frozen images
Using busybox:glibc instead of busybox:latest as the testing image explicitly for those network related test cases.

- What I did
Using busybox:1.27-glibc as the image to test network related test cases (ping issue)
- How I did it
Adding both glibc and latest tagged busybox into frozen images
- How to verify it
make test-integration
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

vdemeester

LGTM 🐸

arm64b · 2018-02-22T09:14:08Z

Thanks @vdemeester for the quick response 👍 !
Just checked the CI result, interesting, seems the service image busybox in the simpleTestService() have to be tagged by latest, otherwise the CreateService() cannot create the busybox /bin/top service.
Because TestAPISwarmHealthcheckNone test case will ping sth, so we have to point the service image to busybox: glibc instead of busybox:latest, that will be a dilemma...
Will investigate further tomorrow.
@vdemeester , @tianon @dnephin @thaJeztah PTAL first?

arm64b · 2018-02-22T09:15:55Z

integration-cli/docker_api_swarm_test.go

dnephin · 2018-02-22T19:20:51Z

changes sgtm

tianon

LGTM

(any particular reason we're pinning explicitly to 1.27-glibc instead of just glibc?)

codecov · 2018-02-23T02:45:30Z

Codecov Report

❗ No coverage uploaded for pull request base (master@6004757). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36375   +/-   ##
=========================================
  Coverage          ?   34.65%           
=========================================
  Files             ?      612           
  Lines             ?    45297           
  Branches          ?        0           
=========================================
  Hits              ?    15697           
  Misses            ?    27543           
  Partials          ?     2057

arm64b · 2018-02-23T07:45:04Z

The only issue we need to resolve for this PR is #36386 , maybe we have some potential problems with the CreateService api?

arm64b · 2018-02-23T07:51:08Z

(any particular reason we're pinning explicitly to 1.27-glibc instead of just glibc?)

No special reason, if any, maybe there're some testing noise in my local system prevent me from avoiding a little big changes, so I'd like to get to the target gradually 🤗

thaJeztah

LGTM if green 😄

Adding `busybox:latest` and `busybox:glibc` as the frozen images Signed-off-by: Dennis Chen <dennis.chen@arm.com>

Using the `busybox:glibc` instead of `busybox:latest` to the network related test cases (`ping` issue). Signed-off-by: Dennis Chen <dennis.chen@arm.com>

arm64b · 2018-02-27T09:28:41Z

Hello @vdemeester , I dig into the CI failure cases last night and make some little tweak for the codes today, now from the CI result, I believe the failure on node powerpc and z are testing noise:
powerpc: ...............................................no space left on device
z: only DockerSwarmSuite.TearDownTest fails

So I bet this time if you rebuild the 2 nodes, we will win 🤗, else I owe you a bottle of beer🐸

arm64b · 2018-02-28T03:14:34Z

Oops, seems I lost a bottle of beer but actually not, because we human beings think the powerpc machine is not reliable recently 😈 This point can be backed by the CI result of the PRs submitted these days...

thaJeztah · 2018-02-28T07:19:59Z

Yeah, restarted the PPC build, I think some of them were cleaned up

arm64b · 2018-02-28T09:42:47Z

OK, thanks @thaJeztah , apparently you are a lucky man, now it's green 😺

thaJeztah · 2018-02-28T09:55:02Z

Can't take credits for that; I think the test-infra team and @vdemeester have been cleaning up nodes that were running out of disk space 🤗

arm64b · 2018-02-28T10:30:46Z

Ah, a very tough CI battle we have experienced together🤗, and from the CI I found we still have some tear-down steps in CI need to be enhanced, so it's not bad thing 👍

arm64b requested review from dnephin and vdemeester as code owners February 22, 2018 07:08

GordonTheTurtle added the status/0-triage label Feb 22, 2018

vdemeester added status/2-code-review and removed status/0-triage labels Feb 22, 2018

vdemeester requested review from thaJeztah and tianon February 22, 2018 08:47

vdemeester approved these changes Feb 22, 2018

View reviewed changes

arm64b commented Feb 22, 2018

View reviewed changes

integration-cli/docker_api_swarm_test.go Outdated

Copy link

Contributor Author

arm64b Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

tianon approved these changes Feb 22, 2018

View reviewed changes

arm64b force-pushed the frozen-busybox-latest-glibc branch from 80c6ef5 to 7770707 Compare February 23, 2018 02:45

arm64b force-pushed the frozen-busybox-latest-glibc branch from 7770707 to dc7aa30 Compare February 23, 2018 05:41

arm64b force-pushed the frozen-busybox-latest-glibc branch from dc7aa30 to 43228ca Compare February 23, 2018 09:21

vdemeester added rebuild/janky labels Feb 23, 2018

GordonTheTurtle removed rebuild/experimental labels Feb 23, 2018

thaJeztah approved these changes Feb 23, 2018

View reviewed changes

yongtang added status/4-merge rebuild/experimental and removed status/2-code-review labels Feb 23, 2018

GordonTheTurtle removed the rebuild/experimental label Feb 23, 2018

yongtang added the rebuild/experimental label Feb 23, 2018

vdemeester added the rebuild/z label Feb 26, 2018

GordonTheTurtle removed rebuild/experimental labels Feb 26, 2018

vdemeester added rebuild/powerpc labels Feb 26, 2018

GordonTheTurtle removed rebuild/powerpc labels Feb 26, 2018

Add busybox:latest into the frozen images

3ae45c5

Adding `busybox:latest` and `busybox:glibc` as the frozen images Signed-off-by: Dennis Chen <dennis.chen@arm.com>

arm64b force-pushed the frozen-busybox-latest-glibc branch from fc3b8c3 to e429c82 Compare February 27, 2018 06:50

Network testing with busybox:glibc

0d31dee

Using the `busybox:glibc` instead of `busybox:latest` to the network related test cases (`ping` issue). Signed-off-by: Dennis Chen <dennis.chen@arm.com>

arm64b force-pushed the frozen-busybox-latest-glibc branch from e429c82 to 0d31dee Compare February 27, 2018 06:53

dnephin added rebuild/powerpc labels Feb 27, 2018

GordonTheTurtle removed rebuild/powerpc labels Feb 27, 2018

arm64b mentioned this pull request Feb 28, 2018

Clean some docker_cli_build_tests that are cli-only #36427

Merged

thaJeztah added the rebuild/powerpc label Feb 28, 2018

GordonTheTurtle removed the rebuild/powerpc label Feb 28, 2018

thaJeztah merged commit 3e0299f into moby:master Feb 28, 2018

arm64b deleted the frozen-busybox-latest-glibc branch February 28, 2018 10:30

thaJeztah added the area/testing label Apr 18, 2018

thaJeztah mentioned this pull request Apr 18, 2018

[18.03] Updates to integration tests, migrate to "gotestyourself" docker-archive/docker-ce#513

Merged

thaJeztah mentioned this pull request Jan 26, 2021

testutil.LoadBusybox() load both "regular" and "glibc" busybox variants #41937

Open

Conversation

arm64b commented Feb 22, 2018

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

arm64b commented Feb 22, 2018

Uh oh!

arm64b Feb 22, 2018

Choose a reason for hiding this comment

Uh oh!

dnephin commented Feb 22, 2018

Uh oh!

tianon left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arm64b commented Feb 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arm64b commented Feb 23, 2018

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

arm64b commented Feb 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arm64b commented Feb 28, 2018

Uh oh!

thaJeztah commented Feb 28, 2018

Uh oh!

arm64b commented Feb 28, 2018

Uh oh!

thaJeztah commented Feb 28, 2018

Uh oh!

arm64b commented Feb 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Feb 23, 2018 •

edited

Loading

arm64b commented Feb 23, 2018 •

edited

Loading

arm64b commented Feb 27, 2018 •

edited

Loading