Enable CRIU on non-amd64 architectures (v2)#36676
Merged
thaJeztah merged 2 commits intomoby:masterfrom Mar 23, 2018
Merged
Conversation
Since the recent release of CRIU has already supported other arches such as AArch64, ppc64le, and s390x, so we can enable it now. Signed-off-by: Dennis Chen <dennis.chen@arm.com>
Using `dpkg --print-architecture` instead of the `uname -m` to abstract the architecture value from the container images, which the build process is running inside, to match exactly the behavior specified by the following Docker file while not 'passthru' to the host. Signed-off-by: Dennis Chen <dennis.chen@arm.com>
ceacd81 to
803a756
Compare
Codecov Report
@@ Coverage Diff @@
## master #36676 +/- ##
==========================================
- Coverage 35.04% 35.04% -0.01%
==========================================
Files 613 613
Lines 45562 45562
==========================================
- Hits 15969 15966 -3
Misses 27486 27486
- Partials 2107 2110 +3 |
Contributor
Author
|
Ping @thaJeztah @tianon @vdemeester @dnephin @kolyshkin @seemethere This PR is a followup for PR #36546, PTAL? |
Contributor
|
LGTM (and thanks!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the recent release of CRIU has already supported other
arches such as AArch64, ppc64le, and s390x, so we can enable
it now.
Additionally, we also use
dpkg --print-architectureinstead ofuname -mto abstract the arch value from the image to avoidsome kind of 'passthru' to the host.
- What I did
Enable CRIU on other arches
- How I did it
Drop the case selection statement
- How to verify it
make binary- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)