Add Cache-Control headers to disable caching /_ping endpoint#38569
Merged
yongtang merged 1 commit intomoby:masterfrom Jan 31, 2019
Merged
Add Cache-Control headers to disable caching /_ping endpoint#38569yongtang merged 1 commit intomoby:masterfrom
yongtang merged 1 commit intomoby:masterfrom
Conversation
The result of this endpoint should not be cached, so it's better to explicitly disable caching. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @cpuguy83 while I'm pinging you... here's another one 😂 |
Codecov Report
@@ Coverage Diff @@
## master #38569 +/- ##
=========================================
Coverage ? 36.65%
=========================================
Files ? 608
Lines ? 45173
Branches ? 0
=========================================
Hits ? 16560
Misses ? 26332
Partials ? 2281 |
wsong
approved these changes
Jan 16, 2019
AkihiroSuda
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of this endpoint should not be cached, so it's better to explicitly disable caching.