testutil.LoadBusybox() load both "regular" and "glibc" busybox variants#41937
Open
thaJeztah wants to merge 1 commit intomoby:masterfrom
Open
testutil.LoadBusybox() load both "regular" and "glibc" busybox variants#41937thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
This makes sure that the swarm tests use the frozen image, instead of
pulling the image from Docker Hub. We already have these images locally,
so loading them (like we do for the non-glibc variant) prevents some
rate limits;
=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestSwarmContainerEndpointOptions (2.71s)
--- FAIL: TestDockerSwarmSuite/TestSwarmContainerEndpointOptions (2.71s)
docker_cli_swarm_test.go:350: assertion failed: error is not nil: exit status 125: Unable to find image 'busybox:glibc' locally
/usr/local/cli/docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.
See '/usr/local/cli/docker run --help'.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Sigh.. doesn't seem to work for some odd reason; it fails to load the image that were were originally loading 🤔 |
Member
Author
|
Looks like those are in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #36375, which added this variant of the busybox image
This makes sure that the swarm tests use the frozen image, instead of pulling the image from Docker Hub. We already have these images locally, so loading them (like we do for the non-glibc variant) prevents some rate limits;