libnetwork: Clean up sysfs-based operations#44802
Merged
neersighted merged 1 commit intomoby:masterfrom Jan 11, 2023
Merged
Conversation
- The oldest kernel version currently supported is v3.10. Bridge parameters can be set through netlink since v3.8 (see torvalds/linux@25c71c7). As such, we don't need to fallback to sysfs to set hairpin mode. - `scanInterfaceStats()` is never called, so no need to keep it alive. - Document why `default_pvid` is set through sysfs Signed-off-by: Albin Kerouanton <albinker@gmail.com>
9da8c95 to
ef161d4
Compare
corhere
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scanInterfaceStats()is never called, so no need to keep it alive.default_pvidis set through sysfs