api/types/filters: Args: use pointer receiver and update tests#45394
Closed
thaJeztah wants to merge 3 commits intomoby:masterfrom
Closed
api/types/filters: Args: use pointer receiver and update tests#45394thaJeztah wants to merge 3 commits intomoby:masterfrom
thaJeztah wants to merge 3 commits intomoby:masterfrom
Conversation
1 task
b75f338 to
c93a606
Compare
c93a606 to
d11e8a7
Compare
d11e8a7 to
7278e74
Compare
7278e74 to
b9a6b9f
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
api/types/filters/parse_test.go:26:25: SA9005: struct type 'github.com/docker/docker/api/types/filters.Args' doesn't have any exported fields, nor custom marshaling (staticcheck)
s, err := json.Marshal(NewArgs())
^
api/types/filters/parse_test.go:31:24: SA9005: struct type 'github.com/docker/docker/api/types/filters.Args' doesn't have any exported fields, nor custom marshaling (staticcheck)
s, err = json.Marshal(Args{})
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b9a6b9f to
b44cc08
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a pointer receiver, to make it easier to use this type without having to call
filter.NewArgs()- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)