Skip to content

[backport 24.0] c8d/pull: Use same progress action as distribution#45602

Merged
thaJeztah merged 1 commit intomoby:24.0from
vvoland:c8d-exists-24
May 24, 2023
Merged

[backport 24.0] c8d/pull: Use same progress action as distribution#45602
thaJeztah merged 1 commit intomoby:24.0from
vvoland:c8d-exists-24

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented May 24, 2023

Docker with containerd integration emits "Exists" progress action when a layer of the currently pulled image already exists. This is different from the non-c8d Docker which emits "Already exists".

This makes both implementations consistent by emitting backwards compatible "Already exists" action.

(cherry picked from commit a7bc65f)

- How to verify it

# Before
$ docker pull ubuntu:22.04
dfd64a3b4296: Exists
6f8fe7bff0be: Exists
3f5ef9003cef: Exists
docker.io/library/ubuntu:22.04

# After
$ docker pull ubuntu:22.04
dfd64a3b4296: Already exists
6f8fe7bff0be: Already exists
3f5ef9003cef: Already exists
docker.io/library/ubuntu:22.04

- Description for the changelog
containerd integration: Make pull emit Already exists progress

- A picture of a cute animal (not mandatory but encouraged)

Docker with containerd integration emits "Exists" progress action when a
layer of the currently pulled image already exists. This is different
from the non-c8d Docker which emits "Already exists".

This makes both implementations consistent by emitting backwards
compatible "Already exists" action.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit a7bc65f)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added area/api API status/2-code-review area/images Image Distribution containerd-integration Issues and PRs related to containerd integration labels May 24, 2023
@vvoland vvoland added this to the 24.0.2 milestone May 24, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ac1c329 into moby:24.0 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API area/images Image Distribution containerd-integration Issues and PRs related to containerd integration status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

3 participants