Conversation
Feature flags are one of the configuration items which can be reloaded without restarting the daemon. Whether the daemon uses the containerd snapshotter service or the legacy graph drivers is controlled by a feature flag. However, much of the code which checks the snapshotter feature flag assumes that the flag cannot change at runtime. Make it so that the snapshotter setting can only be changed by restarting the daemon, even if the flag state changes after a live configuration reload. Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit 9b9c524) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
May 25, 2023
neersighted
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature flags are one of the configuration items which can be reloaded without restarting the daemon. Whether the daemon uses the containerd snapshotter service or the legacy graph drivers is controlled by a feature flag. However, much of the code which checks the snapshotter feature flag assumes that the flag cannot change at runtime. Make it so that the snapshotter setting can only be changed by restarting the daemon, even if the flag state changes after a live configuration reload.
(cherry picked from commit 9b9c524)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)